Differential D9507

p2p: make gtxid(.hash) and fAlreadyHave localvars const
ClosedPublic
Actions

Authored by Fabien on May 12 2021, 14:08.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC0f0d105ce2bf: p2p: make gtxid(.hash) and fAlreadyHave localvars const

Summary

Partial backport of core#19610:
https://github.com/bitcoin/bitcoin/pull/19610/commits/24ee4f01eadb870435712950a1364cf0def06e9f

There is very few remaining when removed the segwit content.

Depends on D9506.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 12 2021, 14:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2021, 14:08

Fabien requested review of this revision.May 12 2021, 14:08

teamcity edited the summary of this revision. (Show Details)May 12 2021, 14:09

Fabien added a child revision: D9508: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing.May 12 2021, 14:15

Harbormaster completed remote builds in B15694: Diff 28433.May 12 2021, 14:24

majcosta accepted this revision.May 12 2021, 14:48

This revision is now accepted and ready to land.May 12 2021, 14:48

Closed by commit rABC0f0d105ce2bf: p2p: make gtxid(.hash) and fAlreadyHave localvars const (authored by Jon Atack <jon@atack.com>, committed by Fabien). · Explain WhyMay 12 2021, 19:12

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0f0d105ce2bf: p2p: make gtxid(.hash) and fAlreadyHave localvars const.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

4 lines

Diff 28449

View Options

p2p: make gtxid(.hash) and fAlreadyHave localvars constClosedPublicActions