Page MenuHomePhabricator

[Cashtab] Bugfix in haveUtxosChanged
ClosedPublic

Authored by bytesofman on May 12 2021, 20:19.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC307cdeee185a: [Cashtab] Bugfix in haveUtxosChanged
Summary

The haveUtxosChanged function always returns true after it was switched to compare utxo from API against previously saved wallet.state utxo set. This means that hydrateUtxos is called every 10s, degrading app performance.

This diff returns to the original way of comparing utxo set.

Additionally, the diff simplifies the function by removing redundant and confusing if/else statements.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-previousUtxo-issue
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15704
Build 31312: Build Diffcashtab-tests
Build 31311: arc lint + arc unit