Differential D9520

[backport#19264] [tests] Don't import asyncio to test magic bytes
ClosedPublic
Actions

Authored by majcosta on May 13 2021, 01:19.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCb97f1a9415a0: [backport#19264] [tests] Don't import asyncio to test magic bytes

Summary

49236be099c5e8b3cadbc98d5216313e7e1a5a45 [tests] Don't import asyncio to test magic bytes (John Newbery)

Pull request description:

Simplify the test for invalid start bytes. No need to import asyncio and the Network thread.

Backport of core#19264

Depends on D9519

Test Plan

ninja all && ./test/functional/test_runner.py p2p_invalid_messages

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 13 2021, 01:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2021, 01:19

majcosta requested review of this revision.May 13 2021, 01:19

teamcity edited the summary of this revision. (Show Details)May 13 2021, 01:20

majcosta added a child revision: D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.May 13 2021, 01:21

Harbormaster completed remote builds in B15708: Diff 28457.May 13 2021, 01:38

PiRK accepted this revision.May 13 2021, 07:39

This revision is now accepted and ready to land.May 13 2021, 07:39

Closed by commit rABCb97f1a9415a0: [backport#19264] [tests] Don't import asyncio to test magic bytes (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyMay 13 2021, 12:31

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb97f1a9415a0: [backport#19264] [tests] Don't import asyncio to test magic bytes.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_invalid_messages.py

33 lines

Diff 28466

test/functional/p2p_invalid_messages.py

Loading...