Page MenuHomePhabricator
Differential D9525

[avalanche] Add a verifyavalancheproof RPC
ClosedPublic
Actions

Authored by Fabien on May 14 2021, 09:36.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC8bc4e1bb590b: [avalanche] Add a verifyavalancheproof RPC
Summary

As the name suggests, it runs the verification on the avalanche proof.

Test Plan
./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 14 2021, 09:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2021, 09:36
Fabien requested review of this revision.May 14 2021, 09:36
Harbormaster completed remote builds in B15719: Diff 28480.May 14 2021, 09:50
Fabien updated this revision to Diff 28483.May 14 2021, 11:02

Add a Proof::FromHex() static deserialization method to avoid duplicating the code

PiRK mentioned this in D9526: [avalanche] add a decodeavalancheproof RPC.May 14 2021, 11:08
Harbormaster completed remote builds in B15722: Diff 28483.May 14 2021, 11:12
Fabien added a child revision: D9529: [avalanche] Consistently use Proof::FromHex() for deserializing a proof.May 14 2021, 11:24
PiRK added a child revision: D9526: [avalanche] add a decodeavalancheproof RPC.May 14 2021, 11:26
majcosta requested changes to this revision.May 14 2021, 17:17
majcosta added a subscriber: majcosta.

i think this RPC is part of the decodeavalancheproof RPC, no?

This revision now requires changes to proceed.May 14 2021, 17:17
Fabien requested review of this revision.May 14 2021, 18:14

No it's a different RPC

majcosta accepted this revision.May 14 2021, 18:57
This revision is now accepted and ready to land.May 14 2021, 18:57
majcosta added inline comments.May 14 2021, 18:59
src/avalanche/proof.h
100–101 ↗(On Diff #28483)

suggestion, rename error to out_error, that way I'd think it's clear enough that you can remove the // error set by FromHex comments in D9529, it's a common enough idiom I think

Fabien updated this revision to Diff 28502.May 17 2021, 07:15

Rename error to errorOut

Harbormaster completed remote builds in B15735: Diff 28502.May 17 2021, 07:31
Closed by commit rABC8bc4e1bb590b: [avalanche] Add a verifyavalancheproof RPC (authored by Fabien). · Explain WhyMay 17 2021, 08:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8bc4e1bb590b: [avalanche] Add a verifyavalancheproof RPC.

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines
68 lines
rpc/
41 lines
test/
functional/
25 lines

Diff 28503

View Options

src/avalanche/proof.h

Loading...
View Options

src/avalanche/proof.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...