Differential D9529

[avalanche] Consistently use Proof::FromHex() for deserializing a proof
ClosedPublic
Actions

Authored by Fabien on May 14 2021, 11:24.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC39b5c01a216d: [avalanche] Consistently use Proof::FromHex() for deserializing a proof

Summary

This deduplicates the proof deserialization code and add error checking
as needed.

Depends on D9525.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proof_fromhex_consistently

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15724
Build 31352: Build Diff	build-debug · lint-circular-dependencies · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 31351: arc lint + arc unit

Event Timeline

Fabien created this revision.May 14 2021, 11:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2021, 11:24

Fabien requested review of this revision.May 14 2021, 11:24

Harbormaster completed remote builds in B15724: Diff 28485.May 14 2021, 11:34

majcosta mentioned this in D9525: [avalanche] Add a verifyavalancheproof RPC.May 14 2021, 18:59

majcosta accepted this revision.May 14 2021, 19:08

This revision is now accepted and ready to land.May 14 2021, 19:08

Closed by commit rABC39b5c01a216d: [avalanche] Consistently use Proof::FromHex() for deserializing a proof (authored by Fabien). · Explain WhyMay 17 2021, 08:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC39b5c01a216d: [avalanche] Consistently use Proof::FromHex() for deserializing a proof.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

9 lines

rpc/

avalanche.cpp

15 lines

Diff 28485

View Options

src/avalanche/processor.cpp