Page MenuHomePhabricator

test: Check that peers with forcerelay permission are not asked to feefilter
ClosedPublic

Authored by Fabien on May 18 2021, 14:41.

Details

Summary

Backport of core#19198.

The signature of util.connect_nodes in our codebase differs from core,
so this has been adapted accordingly.

Test Plan
ninja check-extended

Event Timeline

Fabien requested review of this revision.May 18 2021, 14:41

Failed tests logs:

====== Bitcoin ABC functional tests: abc_mining_basic.py ======

------- Stdout: -------
2021-05-18T14:50:29.322000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210518_144627/abc_mining_basic_499
2021-05-18T14:50:30.097000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 126, in main
    self.run_test()
  File "/work/test/functional/abc_mining_basic.py", line 146, in run_test
    self.run_for_node(self.nodes[1], MINER_FUND_LEGACY_ADDR)
  File "/work/test/functional/abc_mining_basic.py", line 69, in run_for_node
    'minimumvalue': 0,
  File "/work/test/functional/abc_mining_basic.py", line 58, in assert_getblocktemplate
    assert_equal(blockTemplate[key], value)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not({'minerfund': {'addresses': ['2MviGxxFciGeWTgkUgYgjqehWt18c4ZsShd'], 'minimumvalue': 200000000}} == {'minerfund': {'addresses': [], 'minimumvalue': 0}})
2021-05-18T14:50:30.148000Z TestFramework (INFO): Stopping nodes
2021-05-18T14:50:30.250000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210518_144627/abc_mining_basic_499
2021-05-18T14:50:30.251000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210518_144627/abc_mining_basic_499/test_framework.log
2021-05-18T14:50:30.251000Z TestFramework (ERROR): 
2021-05-18T14:50:30.251000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210518_144627/abc_mining_basic_499' to consolidate all logs
2021-05-18T14:50:30.251000Z TestFramework (ERROR): 
2021-05-18T14:50:30.251000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-05-18T14:50:30.251000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-05-18T14:50:30.251000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_mining_basic.py

Unrelated failure, restarting the build.

This revision is now accepted and ready to land.May 18 2021, 18:42