Page MenuHomePhabricator

Add txrequest module
ClosedPublic

Authored by Fabien on May 18 2021, 15:22.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC07731aaf057e: Add txrequest module
Summary
This adds a new module (unused for now) which defines TxRequestTracker,
a data structure that maintains all information about transaction
requests, and coordinates requests.

Partial backport of core#19988:
https://github.com/bitcoin/bitcoin/pull/19988/commits/da3b8fde03f2e8060bb7ff3bff17175dab85f0cd#diff-e3e574cb6dabe01b6149f9d121fc7e286abb49c04442a0a816977ef2a4103ed8

This also includes a GCC workaround that would cause the build to fail:
Partial backport of core#20162. This backport will be completed as
PR19988 is ported because it impacts the code from other commits.

Since this is a lot of changes the tests are done in separate diffs (as
per the PR commits). For now the code is not used so this is safe.

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 18 2021, 15:22
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/txrequest.cpp
600 ↗(On Diff #28527)

this comment is no longer accurate. // return a std::vector<TxId> perhaps?

This revision is now accepted and ready to land.May 20 2021, 03:44
This revision was automatically updated to reflect the committed changes.