Page MenuHomePhabricator

Add txrequest unit tests
ClosedPublic

Authored by Fabien on May 18 2021, 15:29.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC47c22190498b: Add txrequest unit tests
Summary
Add unit tests for TxRequestTracker. Several scenarios are tested,
randomly interleaved with eachother.

Includes a test by Antoine Riard (ariard).

Partial backport of core#19988:
https://github.com/bitcoin/bitcoin/pull/19988/commits/3c7fe0e5a0ee1abf4dc263ae5310e68253c866e1

Partial backport of core#20162.

Depends on D9547.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 18 2021, 15:29
PiRK added inline comments.
src/test/txrequest_tests.cpp
604 ↗(On Diff #28528)

Nit : gtxid1 -> txid1

Fix a couple nits in names

This revision is now accepted and ready to land.May 20 2021, 03:54
This revision was automatically updated to reflect the committed changes.
Mengerian added a task: Restricted Maniphest Task.May 21 2021, 15:59