Page MenuHomePhabricator
Differential D9548

Add txrequest unit tests
ClosedPublic
Actions

Authored by Fabien on May 18 2021, 15:29.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC47c22190498b: Add txrequest unit tests
Summary
Add unit tests for TxRequestTracker. Several scenarios are tested,
randomly interleaved with eachother.

Includes a test by Antoine Riard (ariard).

Partial backport of core#19988:
https://github.com/bitcoin/bitcoin/pull/19988/commits/3c7fe0e5a0ee1abf4dc263ae5310e68253c866e1

Partial backport of core#20162.

Depends on D9547.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 18 2021, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2021, 15:29
Fabien requested review of this revision.May 18 2021, 15:29
teamcity edited the summary of this revision. (Show Details)May 18 2021, 15:29
Fabien added a child revision: D9549: Add txrequest fuzz tests.May 18 2021, 15:32
Harbormaster completed remote builds in B15754: Diff 28528.May 18 2021, 15:43
PiRK added a subscriber: PiRK.May 19 2021, 10:36
PiRK added inline comments.
src/test/txrequest_tests.cpp
604 ↗(On Diff #28528)

Nit : gtxid1 -> txid1

Fabien updated this revision to Diff 28538.May 19 2021, 12:04

Fix a couple nits in names

Harbormaster completed remote builds in B15762: Diff 28538.May 19 2021, 12:14
majcosta accepted this revision.May 20 2021, 03:54
This revision is now accepted and ready to land.May 20 2021, 03:54
Closed by commit rABC47c22190498b: Add txrequest unit tests (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyMay 20 2021, 15:08
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC47c22190498b: Add txrequest unit tests.
Mengerian added a task: Restricted Maniphest Task.May 21 2021, 15:59

Revision Contents
Changeset List

PathSize
src/
test/
3 lines
732 lines
15 lines
153 lines

Diff 28547

View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/txrequest_tests.cpp

Loading...
View Options

src/txrequest.h

Loading...
View Options

src/txrequest.cpp

Loading...