Differential D9559

Move all implementation details from the TxRequestTracker to the header
AbandonedPublic
Actions

Authored by Fabien on May 20 2021, 19:04.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

This is a step toward turning the class into a template that can be used
for tracking transactions and avalanche proofs.

Test Plan

ninja all check-all
./test/functional/test_runner.py p2p_tx_download
ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_txrequest_impl

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15769
Build 31438: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 31437: arc lint + arc unit

Event Timeline

Fabien created this revision.May 20 2021, 19:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2021, 19:04

Fabien requested review of this revision.May 20 2021, 19:04

Note: you can refer to D9557 to see the final result (modulo a few nits found during the diff split)

Fabien added a child revision: D9560: Rename `tx` to `inv` in the TxRequestTracker.May 20 2021, 19:09

Harbormaster completed remote builds in B15769: Diff 28556.May 20 2021, 19:23

So, actually, I think this is wrong.

You had a PIMPL pattern that was working nicely for you. You have zero reason to break this. Just make the private implementation work with uint256, and only templatize the wrapper.

This revision now requires changes to proceed.May 20 2021, 22:42

Mengerian added a task: Restricted Maniphest Task.May 21 2021, 17:02

Fabien removed a child revision: D9560: Rename `tx` to `inv` in the TxRequestTracker.May 21 2021, 21:26

Fabien abandoned this revision.May 27 2021, 19:03