Page MenuHomePhabricator

Make the implementation details of TxRequestTracker use an uint256
ClosedPublic

Authored by Fabien on May 21 2021, 19:57.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC482241144118: Make the implementation details of TxRequestTracker use an uint256
Summary

Instead of a TxId. The public interfaces are left unchanged. This is a
step toward making it a template class able to handle both transactions
and proofs, which are uint256 subclasses.

There is a tweak to make the type conversion from the GetRequestable
public interface, which involves updating the signature of the internal
implementation.

Test Plan
ninja all check-all
./test/functional/test_runner.py p2p_tx_download
ninja bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable