Differential D9593

Split cs_main lock when sending getdata between inv types
ClosedPublic
Actions

Authored by Fabien on May 26 2021, 20:19.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCbe9b4b0ab750: Split cs_main lock when sending getdata between inv types

Summary

It is necessary to release the lock for dealing with proof getdata
requests. The state does not need to be accessed in the second lock
block, which should give confidence that this will not cause any issue.

Depends on D9592.

Test Plan

With clang and debug:

ninja all check-all

Run the tsan build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 26 2021, 20:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2021, 20:19

Fabien requested review of this revision.May 26 2021, 20:19

@bot build-tsan

teamcity awarded a token.May 26 2021, 20:20

Harbormaster completed remote builds in B15823: Diff 28627.May 26 2021, 20:33

deadalnix accepted this revision.May 26 2021, 21:37

This revision is now accepted and ready to land.May 26 2021, 21:37

Closed by commit rABCbe9b4b0ab750: Split cs_main lock when sending getdata between inv types (authored by Fabien). · Explain WhyMay 27 2021, 08:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCbe9b4b0ab750: Split cs_main lock when sending getdata between inv types.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

47 lines

Diff 28634

View Options

Split cs_main lock when sending getdata between inv typesClosedPublicActions