Page MenuHomePhabricator

[LINTER] Add an exception for a cppcheck false positive
ClosedPublic

Authored by Fabien on May 27 2021, 11:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5f4018d6aff3: [LINTER] Add an exception for a cppcheck false positive
Summary

There is a false positive out of bounds reported in the
processor_tests.cpp. The size of the accessed array is asserted just
before accessing the element so there is no possible issue, but some
combination of boost/cppcheck fail to determine this (e.g. ArchLinux).

Test Plan

Edit processor_tests.cpp with some dummy changes, then run arc lint.
Before the patch cppcheck reports errors, after the patch arc lint is
happy.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cppcheck_exception
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15827
Build 31554: Build Diff
Build 31553: arc lint + arc unit