Page MenuHomePhabricator
Differential D9607

[avalanche] Make the peer hold a shared pointer to the proof
ClosedPublic
Actions

Authored by Fabien on May 31 2021, 12:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCdbc7bb707be2: [avalanche] Make the peer hold a shared pointer to the proof
Summary

Doing so will make it possible to share the proof ownership while being
safe if the peer is deleted in the meantime.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
peermanager_proof_sharedptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15854
Build 31608: Build Diffbuild-without-wallet · build-diff · build-debug · lint-circular-dependencies · build-clang-tidy · build-clang
Build 31607: arc lint + arc unit

Event Timeline

Fabien created this revision.May 31 2021, 12:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2021, 12:06
Fabien requested review of this revision.May 31 2021, 12:06
Fabien added a child revision: D9595: [avalanche] Add an API to store and retrieve a proof.May 31 2021, 12:11
Harbormaster completed remote builds in B15854: Diff 28676.May 31 2021, 12:17
deadalnix accepted this revision.May 31 2021, 14:45
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/rpc/avalanche.cpp
429

Is that really needed?

This revision is now accepted and ready to land.May 31 2021, 14:45
deadalnix added a comment.May 31 2021, 14:45

Please go on with this.

Fabien added a child revision: D9616: [avalanche] Make the peermanager methods use a shared pointer to proof.Jun 1 2021, 14:23
Fabien removed a child revision: D9595: [avalanche] Add an API to store and retrieve a proof.Jun 1 2021, 14:50
Closed by commit rABCdbc7bb707be2: [avalanche] Make the peer hold a shared pointer to the proof (authored by Fabien). · Explain WhyJun 2 2021, 06:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdbc7bb707be2: [avalanche] Make the peer hold a shared pointer to the proof.

Revision Contents
Changeset List

PathSize
src/
avalanche/
11 lines
4 lines
rpc/
2 lines

Diff 28676

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...