Differential D9616

[avalanche] Make the peermanager methods use a shared pointer to proof
ClosedPublic
Actions

Authored by Fabien on Jun 1 2021, 14:23.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0c1b7cdfed8f: [avalanche] Make the peermanager methods use a shared pointer to proof

Summary

The public interfaces from the processor are not migrated yet and will
be in their own diff so the changes remain easy to review.

Depends on D9607.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 1 2021, 14:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2021, 14:23

Fabien requested review of this revision.Jun 1 2021, 14:23

Fabien added a child revision: D9617: [avalanche] Make the processor methods use a shared pointer to proof.Jun 1 2021, 14:31

Harbormaster completed remote builds in B15866: Diff 28696.Jun 1 2021, 14:38

Your strategy seems scary. How are you going to track down all the calls to make_shared<Proof> ?

in any case, don't create copies for no reasons.

src/avalanche/peermanager.cpp
18 ↗	(On Diff #28696)	Don't change the behavior in a middle of a refactoring.
24 ↗	(On Diff #28696)	No need for move if you pass by const ref.
src/avalanche/peermanager.h
131 ↗	(On Diff #28696)	See comment for getPeerId
155 ↗	(On Diff #28696)	Don't cause unnecessary copies. Pass by const ref unless you take ownership of a new reference.
186 ↗	(On Diff #28696)	dito

This revision now requires changes to proceed.Jun 1 2021, 15:24

Revert behavior change, use const ref to shared pointers, use auto where applicable

deadalnix accepted this revision.Jun 2 2021, 12:03

This revision is now accepted and ready to land.Jun 2 2021, 12:03

Harbormaster completed remote builds in B15879: Diff 28715.Jun 2 2021, 15:43

Closed by commit rABC0c1b7cdfed8f: [avalanche] Make the peermanager methods use a shared pointer to proof (authored by Fabien). · Explain WhyJun 2 2021, 15:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0c1b7cdfed8f: [avalanche] Make the peermanager methods use a shared pointer to proof.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

10 lines

peermanager.cpp

14 lines

6 lines

test/

peermanager_tests.cpp

38 lines

processor_tests.cpp

18 lines

Diff 28725

src/avalanche/peermanager.h

Loading...

src/avalanche/peermanager.cpp

Loading...

src/avalanche/processor.cpp

Loading...

src/avalanche/test/peermanager_tests.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...