The public interfaces from the processor are not migrated yet and will
be in their own diff so the changes remain easy to review.
Depends on D9607.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC0c1b7cdfed8f: [avalanche] Make the peermanager methods use a shared pointer to proof
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- shared_internal
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15879 Build 31658: Build Diff lint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang Build 31657: arc lint + arc unit
Event Timeline
Comment Actions
Your strategy seems scary. How are you going to track down all the calls to make_shared<Proof> ?
in any case, don't create copies for no reasons.
| src/avalanche/peermanager.cpp | ||
|---|---|---|
| 18 ↗ | (On Diff #28696) | Don't change the behavior in a middle of a refactoring. |
| 24 ↗ | (On Diff #28696) | No need for move if you pass by const ref. |
| src/avalanche/peermanager.h | ||
| 131 ↗ | (On Diff #28696) | See comment for getPeerId |
| 155 ↗ | (On Diff #28696) | Don't cause unnecessary copies. Pass by const ref unless you take ownership of a new reference. |
| 186 ↗ | (On Diff #28696) | dito |