Make SetMiscWarning() accept bilingual_str argument
ClosedPublic
Actions

Authored by PiRK on May 31 2021, 14:12.

Details

Reviewers

Fabien
majcosta

Group Reviewers

Restricted Project

Commits

rABC1a0013532d61: Make SetMiscWarning() accept bilingual_str argument

Summary

refactor: Make GetWarnings() bilingual_str aware internally

https://github.com/bitcoin/bitcoin/pull/19233/commits/38e33aa481cefbe12c50f344bae190c0d95fb489

Make GetWarnings() return bilingual_str

https://github.com/bitcoin/bitcoin/pull/19233/commits/d1ae7c0355662481a7d181a0a458284936d53eb1

Make SetMiscWarning() accept bilingual_str argument

https://github.com/bitcoin/bitcoin/pull/19233/commits/d49612f98add29066817b7c808b76c2d728948e5

This is a backport of core#19233

Test Plan

ninja all check-all

grep -r SetMiscWarning src/

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19233

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15862
Build 31624: Build Diff	build-clang · build-diff · build-debug · lint-circular-dependencies · build-without-wallet · build-clang-tidy
Build 31623: arc lint + arc unit

Event Timeline

PiRK created this revision.May 31 2021, 14:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2021, 14:12

PiRK requested review of this revision.May 31 2021, 14:12

teamcity edited the summary of this revision. (Show Details)May 31 2021, 14:13

PiRK edited the test plan for this revision. (Show Details)May 31 2021, 14:26

Harbormaster completed remote builds in B15858: Diff 28681.May 31 2021, 14:34

Fabien accepted this revision.May 31 2021, 19:35

This revision is now accepted and ready to land.May 31 2021, 19:35

looks like we're missing something in validation.cpp

src/warnings.cpp
44 ↗	(On Diff #28681)	should this be removed? it is removed in the original PR

This revision now requires changes to proceed.May 31 2021, 19:37

remove an unused string in warnings.cpp

Regarding the difference in validation.cpp, I wasn't able to figure out why they have more occurences of SetMiscWarning than we do. I grepped for it, and for the missing AppendWarning function. On git blame it seems like old code that we no longer have, not new code that we haven't backported yet.