[LINTER] Exclude a new rule that enforce naming convention on classes
ClosedPublic
Actions

Authored by Fabien on May 31 2021, 18:38.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf134ffe4b6f9: [LINTER] Exclude a new rule that enforce naming convention on classes

Summary

The Generic.NamingConventions.AbstractClassNamePrefix is new from
phpcs version 3.6.0 and not consistent with our codebase.

Test Plan

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Branch

phpcs_abstract

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15859
Build 31618: Build Diff
Build 31617: arc lint + arc unit

Event Timeline

Fabien created this revision.May 31 2021, 18:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 31 2021, 18:38

Fabien requested review of this revision.May 31 2021, 18:38

Harbormaster completed remote builds in B15859: Diff 28682.May 31 2021, 18:38

majcosta accepted this revision.May 31 2021, 18:46

This revision is now accepted and ready to land.May 31 2021, 18:46

Fabien retitled this revision from [LINTER] Exclude a new rule that enforce naming convention on classes to [LINTER] Exclude new rules that enforce naming conventions on classes.May 31 2021, 18:54

Fabien edited the summary of this revision. (Show Details)

Add another similar exclusion

Harbormaster completed remote builds in B15860: Diff 28683.May 31 2021, 18:54

Closed by commit rABCf134ffe4b6f9: [LINTER] Exclude a new rule that enforce naming convention on classes (authored by Fabien). · Explain WhyMay 31 2021, 18:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf134ffe4b6f9: [LINTER] Exclude a new rule that enforce naming convention on classes.

Revision Contents
Changeset List

Path

Size

arcanist/

phpcs.xml

1 line

Diff 28682

View Options

[LINTER] Exclude a new rule that enforce naming convention on classesClosedPublicActions