Similar to what is done for the peermanager, the processor can benefit
for dealing with proof shared pointers.
Depends on D9616.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC470c7b10647b: [avalanche] Make the processor methods use a shared pointer to proof
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- shared_processor
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15884 Build 31668: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 31667: arc lint + arc unit
Event Timeline
| src/avalanche/processor.cpp | ||
|---|---|---|
| 257 ↗ | (On Diff #28697) | Start with a smart pointer instead of doing these. |
| 446 ↗ | (On Diff #28697) | const ref |
| 449 ↗ | (On Diff #28697) | and you won't need a move |
| src/avalanche/processor.h | ||
| 292 ↗ | (On Diff #28697) | const ref |
| src/avalanche/test/processor_tests.cpp | ||
| 131 ↗ | (On Diff #28697) | It's been several instance of GetProof that lead to a make_shared, this is indicative of a problem. |
| 132 ↗ | (On Diff #28697) | dito |
| src/rpc/avalanche.cpp | ||
| 94 ↗ | (On Diff #28697) | You are taking a reference to a temporary. Just revert. |
| src/avalanche/processor.cpp | ||
|---|---|---|
| 218 ↗ | (On Diff #28716) | Just assign something, reset is really cumbrsome. |