Since BCHD unconditionally disconnects from nodes containing the "Bitcoin ABC" string, we cannot use it to connect to a Bitcoin ABC node, even if connected directly using -connect. This option allows to circumvent that feature.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project
|2302 ↗||(On Diff #28780)|
Why? And if that is a requirement, why not ask for a client name and a version number rather than this?
|2319 ↗||(On Diff #28780)|
|3158 ↗||(On Diff #28780)|
You are branching twice on the same condition for pretty much the same reason (see here comment).
This is indicative of brittle design. For instance, if you take client name + version, then you can simply use the same function in both cases, but if you do not, then you can still create a default uaclient from CLIENT_NAME and CLIENT_VERSION. Either way, this current way of doing it doesn't make sense.