RPC_DESERIALIZATION_ERROR is a better code than
RPC_INVALID_PARAMETER when an hex proof cannot be deserialized.
Ref T1611.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rABC350aba92a742: [avalanche] Make the deserialization error code consistent between RPCs
./test/functional/test_runner.py abc_rpc_avalancheproof
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_rpc_consistent_error_code
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15940 Build 31780: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 31779: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log:
[393/452] bitcoin: testing finalization_tests [394/452] bitcoin: testing scheduler_tests [395/452] Running utility command for check-bitcoin-finalization_tests [396/452] Running utility command for check-bitcoin-scheduler_tests [397/452] bitcoin: testing script_commitment_tests [398/452] bitcoin: testing blockfilter_index_tests [399/452] bitcoin: testing wallet_tests [400/452] Running utility command for check-bitcoin-script_commitment_tests [401/452] Running utility command for check-bitcoin-blockfilter_index_tests [402/452] Running utility command for check-bitcoin-wallet_tests [403/452] bitcoin: testing bip32_tests [404/452] bitcoin: testing torcontrol_tests [405/452] bitcoin: testing sync_tests [406/452] Running utility command for check-bitcoin-bip32_tests [407/452] Running utility command for check-bitcoin-torcontrol_tests [408/452] Running utility command for check-bitcoin-sync_tests [409/452] bitcoin: testing validation_flush_tests [410/452] bitcoin: testing timedata_tests [411/452] Running utility command for check-bitcoin-validation_flush_tests [412/452] bitcoin: testing streams_tests [413/452] Running utility command for check-bitcoin-timedata_tests [414/452] Running utility command for check-bitcoin-streams_tests [415/452] bitcoin: testing compilerbug_tests [416/452] bitcoin: testing checkpoints_tests [417/452] Running utility command for check-bitcoin-compilerbug_tests [418/452] Running utility command for check-bitcoin-checkpoints_tests [419/452] bitcoin: testing txvalidationcache_tests [420/452] bitcoin: testing validationinterface_tests [421/452] Running utility command for check-bitcoin-txvalidationcache_tests [422/452] Running utility command for check-bitcoin-validationinterface_tests [423/452] bitcoin: testing blockstatus_tests [424/452] Running utility command for check-bitcoin-blockstatus_tests [425/452] bitcoin: testing cuckoocache_tests [426/452] bitcoin: testing serialize_tests [427/452] bitcoin: testing schnorr_tests [428/452] Running utility command for check-bitcoin-serialize_tests [429/452] bitcoin: testing cashaddr_tests [430/452] Running utility command for check-bitcoin-schnorr_tests [431/452] Running utility command for check-bitcoin-cuckoocache_tests [432/452] Running utility command for check-bitcoin-cashaddr_tests [433/452] bitcoin: testing op_reversebytes_tests [434/452] Running utility command for check-bitcoin-op_reversebytes_tests [435/452] bitcoin: testing versionbits_tests [436/452] Running utility command for check-bitcoin-versionbits_tests [437/452] bitcoin: testing radix_tests [438/452] Running utility command for check-bitcoin-radix_tests [439/452] bitcoin: testing script_tests [440/452] bitcoin: testing monolith_opcodes_tests [441/452] Running utility command for check-bitcoin-script_tests [442/452] Running utility command for check-bitcoin-monolith_opcodes_tests [443/452] bitcoin: testing crypto_tests [444/452] Running utility command for check-bitcoin-crypto_tests [445/452] bitcoin: testing transaction_tests [446/452] Running utility command for check-bitcoin-transaction_tests [447/452] bitcoin: testing blockcheck_tests [448/452] Running utility command for check-bitcoin-blockcheck_tests [449/452] bitcoin: testing coins_tests [450/452] Running utility command for check-bitcoin-coins_tests ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1