Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb48da90d1e72: [refactor] set the -ecash CLI argument earlier in startup

Summary

init.cpp isn't executed for bitcoin-tx, for example, which also needs the -ecash switch available

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move_ecash_arg_setting

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15955
Build 31810: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-clang-tidy · build-clang · build-diff
Build 31809: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 9 2021, 20:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2021, 20:09

majcosta requested review of this revision.Jun 9 2021, 20:09

Harbormaster completed remote builds in B15951: Diff 28828.Jun 9 2021, 20:24

Fabien requested changes to this revision.Jun 10 2021, 06:56

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/chainparamsbase.cpp
34 ↗	(On Diff #28828)	Like I pointed out in D9652 this is not a chain param. You don't end up on another chain by turning this switch on or off. BTW the category reflects that.

This revision now requires changes to proceed.Jun 10 2021, 06:56

do not set the parameter in an inappropriate function, create a compilation unit for currency unit related code

Harbormaster completed remote builds in B15954: Diff 28831.Jun 10 2021, 07:34

missing newline at end of file

Harbormaster completed remote builds in B15955: Diff 28832.Jun 10 2021, 08:03

Fabien requested changes to this revision.Jun 10 2021, 08:31

Fabien added inline comments.

src/currencyunit.cpp
11	Turn the false default into a constant so you have a single place to edit when making it the default
src/currencyunit.h
10	give the param a name

This revision now requires changes to proceed.Jun 10 2021, 08:31

addressed feedback

Fabien accepted this revision.Jun 10 2021, 09:05

Fabien added inline comments.

src/currencyunit.cpp
12 ↗	(On Diff #28833)	Nit: Default => default

This revision is now accepted and ready to land.Jun 10 2021, 09:05

Harbormaster completed remote builds in B15956: Diff 28833.Jun 10 2021, 09:06

Closed by commit rABCb48da90d1e72: [refactor] set the -ecash CLI argument earlier in startup (authored by majcosta). · Explain WhyJun 10 2021, 09:09

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCb48da90d1e72: [refactor] set the -ecash CLI argument earlier in startup.

[refactor] set the -ecash CLI argument earlier in startup
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28832

src/CMakeLists.txt

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoin-wallet.cpp

src/currencyunit.h

src/currencyunit.cpp

src/init.cpp

[refactor] set the -ecash CLI argument earlier in startupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28832

src/CMakeLists.txt

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoin-wallet.cpp

src/currencyunit.h

src/currencyunit.cpp

src/init.cpp

[refactor] set the -ecash CLI argument earlier in startup
ClosedPublic
Actions

Revision Contents
Changeset List