Page MenuHomePhabricator
Differential D9680

util: Add Assume() identity function
ClosedPublic
Actions

Authored by Fabien on Jun 15 2021, 06:44.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC12031e53db48: util: Add Assume() identity function
Summary
This is needed for #20138. Please refer to the added documentation for
motivation.

Backport of core#20255.

Depends on D9681.

Comes with a linter fix for an edge case where a macro defining
((void)(val)) would be linted as (()(val)).

Ref T1611.

Test Plan

With and without debug:

ninja all check

Diff Detail

Event Timeline

Fabien created this revision.Jun 15 2021, 06:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2021, 06:44
Fabien requested review of this revision.Jun 15 2021, 06:44
teamcity edited the summary of this revision. (Show Details)Jun 15 2021, 06:45
Fabien planned changes to this revision.Jun 15 2021, 06:49
Harbormaster completed remote builds in B16011: Diff 28915.Jun 15 2021, 07:08
Fabien updated this revision to Diff 28917.Jun 15 2021, 07:10

Rebase on top of D9681

Fabien edited the summary of this revision. (Show Details)Jun 15 2021, 07:10
Fabien added a parent revision: D9681: util: Make Assert work with any value.
Fabien added a child revision: D9682: net: Assume that SetCommonVersion is called at most once per peer.Jun 15 2021, 07:22
Harbormaster completed remote builds in B16013: Diff 28917.Jun 15 2021, 07:28
PiRK accepted this revision.Jun 15 2021, 11:51
This revision is now accepted and ready to land.Jun 15 2021, 11:51
Closed by commit rABC12031e53db48: util: Add Assume() identity function (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJun 15 2021, 12:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC12031e53db48: util: Add Assume() identity function.

Revision Contents
Changeset List

PathSize
arcanist/
linter/
2 lines
doc/
27 lines
src/
5 lines
util/
23 lines

Diff 28915

View Options

arcanist/linter/CppVoidParameterLinter.php

Loading...
View Options

doc/developer-notes.md

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/util/check.h

Loading...