Differential D9683

Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress)
ClosedPublic
Actions

Authored by Fabien on Jun 15 2021, 09:52.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC8d18902f617c: Make it easier to reason about node eviction by removing unused…

Summary

Backport of core#20302.

Depends on D9682.

Ref T1611.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20302

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16015
Build 31926: Build Diff	build-without-wallet · build-clang-tidy · lint-circular-dependencies · build-clang · build-diff · build-debug
Build 31925: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 15 2021, 09:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2021, 09:52

Fabien requested review of this revision.Jun 15 2021, 09:52

teamcity edited the summary of this revision. (Show Details)Jun 15 2021, 09:52

Harbormaster completed remote builds in B16015: Diff 28919.Jun 15 2021, 10:06

Fabien added a child revision: D9684: net: Add unit testing of node eviction logic.Jun 15 2021, 10:14

PiRK accepted this revision.Jun 15 2021, 11:57

This revision is now accepted and ready to land.Jun 15 2021, 11:57

Closed by commit rABC8d18902f617c: Make it easier to reason about node eviction by removing unused… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJun 15 2021, 12:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8d18902f617c: Make it easier to reason about node eviction by removing unused….

Revision Contents
Changeset List

Path

Size

src/

net.cpp

2 lines

Diff 28919

View Options

Make it easier to reason about node eviction by removing unused NodeEvictionCandidate::addr (CAddress)ClosedPublicActions