Details

Reviewers

Group Reviewers

Restricted Project

Summary

guarantees nExtraNonce will not have the same value between two consecutive calls, alternative to D9694 without the rand32()

Test Plan

ninja all check check-functional
for i in {1..100}; do ./test/functional/test_runner.py rpc_dumptxoutset; done

Diff Detail

Repository

rABC Bitcoin ABC

Branch

make_extranonce_static

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16042
Build 31978: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 31977: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 24 2021, 08:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2021, 08:40

majcosta requested review of this revision.Jun 24 2021, 08:40

forgot the most important line

Harbormaster completed remote builds in B16042: Diff 28962.Jun 24 2021, 08:55

ensure nExtraNonce is changed in exactly one place, fix expected block hashes in rpc_dumptxoutset

majcosta edited the test plan for this revision. (Show Details)Jun 24 2021, 09:00

use a smaller integer

Harbormaster completed remote builds in B16043: Diff 28963.Jun 24 2021, 09:14

Harbormaster completed remote builds in B16044: Diff 28964.Jun 24 2021, 09:25

... do it consistently

Harbormaster completed remote builds in B16045: Diff 28965.Jun 24 2021, 09:47

No, this is not thread safe.

This revision now requires changes to proceed.Jun 24 2021, 11:39

synchronize static variable, remove static uint256 hashPrevBlock which is now dead code

Harbormaster completed remote builds in B16051: Diff 28971.Jun 24 2021, 15:25

uint8 is just 256 values, this would make it impossible to CPU mine on testnet or whatnot.

src/miner.cpp
547 ↗	(On Diff #28971)	Please don't use these fast whatever crap.
551 ↗	(On Diff #28971)	Relaxed is wrong, here.

This revision now requires changes to proceed.Jun 24 2021, 16:24

use uint32_t instead and use default std::memory_order_seq_cst for atomic increment

Harbormaster completed remote builds in B16053: Diff 28973.Jun 24 2021, 18:06

majcosta abandoned this revision.Sep 7 2022, 18:30

make nExtraNonce static to IncrementExtraNonce
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28962

src/miner.h

src/miner.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/miner_tests.cpp

src/test/util/setup_common.cpp

make nExtraNonce static to IncrementExtraNonceAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28962

src/miner.h

src/miner.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/miner_tests.cpp

src/test/util/setup_common.cpp

make nExtraNonce static to IncrementExtraNonce
AbandonedPublic
Actions

Revision Contents
Changeset List