Page MenuHomePhabricator

net: Add -networkactive option
ClosedPublic

Authored by PiRK on Jun 30 2021, 12:49.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC9f9dcac4297f: net: Add -networkactive option
Summary

Some Bitcoin activity is completely local (offline), e.g., reindexing.

The setnetworkactive RPC command is already present. This PR adds the corresponding command-line argument / config option, and allows to start the client with disabled p2p network by providing -networkactive=0 or -nonetworkactive.

Commit message #1:

net: Add -networkactive option

The `setnetworkactive' RPC command is already present.
This new option allows to start the client with disabled p2p network
activity for testing or reindexing.

Commit message #2:

net: Log network activity status change unconditionally

Commit message #3:

test: Add test coverage for -networkactive option

This is a backport of core#19473

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Jun 30 2021, 12:49
This revision is now accepted and ready to land.Jun 30 2021, 13:46

This deserves some release notes

rebase on D9715 and add release notes