Page MenuHomePhabricator
Differential D9734

[core#19011 1/3] RPCConsole, take initial chaintip data as parameter
ClosedPublic
Actions

Authored by PiRK on Jul 5 2021, 07:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCee8a058bda8a: [core#19011 1/3] RPCConsole, take initial chaintip data as parameter
Summary

PR description: Reduce cs_main lock accumulation during GUI startup

During the GUI startup, there is currently an accumulation of cs_main locks due to setting initial chain state values at multiple locations (in the GUI main thread).

This PR tries to cache the initial chain state (tip height, tip time, best header, etc.) short after loading the blockindex.

The cached values are then used instead of fetching them again (and thus locking cs_main) during setting the client model.

This should fix the initial GUI blocking often experienced during or short after the splashscreen.

This is a backport of core#19011 [1/4]
https://github.com/bitcoin/bitcoin/pull/19011/commits/25e1d0bf417237caa5d36b4e757f29e6c8be8aad

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 5 2021, 07:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2021, 07:52
PiRK requested review of this revision.Jul 5 2021, 07:52
teamcity edited the summary of this revision. (Show Details)Jul 5 2021, 07:52
PiRK added a child revision: D9735: [core#19011 2/3] Add BlockAndHeaderTipInfo to the node interface/appInit.Jul 5 2021, 07:55
teamcity edited the summary of this revision. (Show Details)Jul 5 2021, 07:57
PiRK edited the summary of this revision. (Show Details)Jul 5 2021, 07:59
Harbormaster completed remote builds in B16103: Diff 29058.Jul 5 2021, 08:07
Fabien edited the summary of this revision. (Show Details)Jul 5 2021, 14:44
Fabien accepted this revision.Jul 5 2021, 14:59
This revision is now accepted and ready to land.Jul 5 2021, 14:59
Closed by commit rABCee8a058bda8a: [core#19011 1/3] RPCConsole, take initial chaintip data as parameter (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by PiRK). · Explain WhyJul 6 2021, 07:13
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCee8a058bda8a: [core#19011 1/3] RPCConsole, take initial chaintip data as parameter.

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
11 lines

Diff 29068

View Options

src/qt/rpcconsole.h

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...