Page MenuHomePhabricator

[core#19104] gui, refactor: Register Qt meta types in application constructor
ClosedPublic

Authored by PiRK on Mon, Jul 5, 08:39.

Details

Summary

Backport note: Amount is not a typedef, so I moved it above the Register typedefs comment, and I removed the IMPORTANT TODO comment which has already been address (line 65: Q_DECLARE_METATYPE(Amount))

This is a backport of core#19104

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Jul 5, 08:40
majcosta requested changes to this revision.Mon, Jul 5, 13:27
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/qt/bitcoin.cpp
80 ↗(On Diff #29061)

our Amount is not a typedef int64_t CAmount like in the Core codebase, you might want to check whether you don't want this to be qRegisterMetaType<Amount>(); instead

This revision now requires changes to proceed.Mon, Jul 5, 13:27

address review: use template <typename T> int qMetaTypeId() instead of template <typename T> int qRegisterMetaType(const char *typeName) for amount

This revision is now accepted and ready to land.Mon, Jul 5, 16:07