[core#19104] gui, refactor: Register Qt meta types in application constructor
ClosedPublic
Actions

Authored by PiRK on Jul 5 2021, 08:39.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC874450266794: [core#19104] gui, refactor: Register Qt meta types in application constructor

Summary

Backport note: Amount is not a typedef, so I moved it above the Register typedefs comment, and I removed the IMPORTANT TODO comment which has already been address (line 65: Q_DECLARE_METATYPE(Amount))

This is a backport of core#19104

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16106
Build 32086: Build Diff	build-diff · build-debug · lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy
Build 32085: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 5 2021, 08:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2021, 08:40

PiRK requested review of this revision.Jul 5 2021, 08:40

teamcity edited the summary of this revision. (Show Details)Jul 5 2021, 08:40

PiRK added a child revision: D9736: [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup.Jul 5 2021, 08:41

Harbormaster completed remote builds in B16106: Diff 29061.Jul 5 2021, 08:50

majcosta requested changes to this revision.Jul 5 2021, 13:27

majcosta added a subscriber: majcosta.

majcosta added inline comments.

src/qt/bitcoin.cpp
80	our Amount is not a `typedef int64_t CAmount` like in the Core codebase, you might want to check whether you don't want this to be `qRegisterMetaType<Amount>();` instead

This revision now requires changes to proceed.Jul 5 2021, 13:27

address review: use template <typename T> int qMetaTypeId() instead of template <typename T> int qRegisterMetaType(const char *typeName) for amount

Harbormaster completed remote builds in B16111: Diff 29066.Jul 5 2021, 15:44

majcosta accepted this revision.Jul 5 2021, 16:07

This revision is now accepted and ready to land.Jul 5 2021, 16:07

Closed by commit rABC874450266794: [core#19104] gui, refactor: Register Qt meta types in application constructor (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by PiRK). · Explain WhyJul 6 2021, 07:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC874450266794: [core#19104] gui, refactor: Register Qt meta types in application constructor.