Page MenuHomePhabricator

[avalanche] Activate automated peer discovery
ClosedPublic

Authored by Fabien on Jul 5 2021, 14:42.

Details

Reviewers
PiRK
baby636
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC203162c4df4e: [avalanche] Activate automated peer discovery
Summary

This diff makes the nodes to be added upon reception of a avahello
message. This feature is hidden behind a dedicated flag so one can
choose to only bind manually submitted nodes.

Depends on D9703.

Ref T1634.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_activate_peer_discovery
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16110
Build 32094: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-clang-tidy · build-diff
Build 32093: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jul 5 2021, 14:42
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/abc_p2p_avalanche_peer_discovery.py
240

immediately

This revision is now accepted and ready to land.Jul 6 2021, 08:13

Tail of the build log:

[390/449] bitcoin: testing script_commitment_tests
[391/449] Running utility command for check-bitcoin-wallet_crypto_tests
[392/449] Running utility command for check-bitcoin-merkleblock_tests
[393/449] bitcoin: testing bip32_tests
[394/449] bitcoin: testing sighashtype_tests
[395/449] Running utility command for check-bitcoin-script_commitment_tests
[396/449] bitcoin: testing torcontrol_tests
[397/449] Running utility command for check-bitcoin-bip32_tests
[398/449] Running utility command for check-bitcoin-sighashtype_tests
[399/449] Running utility command for check-bitcoin-torcontrol_tests
[400/449] bitcoin: testing cuckoocache_tests
[401/449] bitcoin: testing settings_tests
[402/449] Running utility command for check-bitcoin-cuckoocache_tests
[403/449] bitcoin: testing scriptpubkeyman_tests
[404/449] Running utility command for check-bitcoin-settings_tests
[405/449] bitcoin: testing timedata_tests
[406/449] bitcoin: testing streams_tests
[407/449] Running utility command for check-bitcoin-scriptpubkeyman_tests
[408/449] Running utility command for check-bitcoin-streams_tests
[409/449] Running utility command for check-bitcoin-timedata_tests
[410/449] bitcoin: testing uint256_tests
[411/449] Running utility command for check-bitcoin-uint256_tests
[412/449] bitcoin: testing script_standard_tests
[413/449] bitcoin: testing txvalidationcache_tests
[414/449] bitcoin: testing wallet_tests
[415/449] Running utility command for check-bitcoin-script_standard_tests
[416/449] Running utility command for check-bitcoin-txvalidationcache_tests
[417/449] Running utility command for check-bitcoin-wallet_tests
[418/449] bitcoin: testing serialize_tests
[419/449] Running utility command for check-bitcoin-serialize_tests
[420/449] bitcoin: testing cashaddr_tests
[421/449] bitcoin: testing getarg_tests
[422/449] bitcoin: testing radix_tests
[423/449] Running utility command for check-bitcoin-cashaddr_tests
[424/449] bitcoin: testing versionbits_tests
[425/449] bitcoin: testing blockcheck_tests
[426/449] Running utility command for check-bitcoin-getarg_tests
[427/449] Running utility command for check-bitcoin-radix_tests
[428/449] bitcoin: testing schnorr_tests
[429/449] Running utility command for check-bitcoin-versionbits_tests
[430/449] Running utility command for check-bitcoin-blockcheck_tests
[431/449] Running utility command for check-bitcoin-schnorr_tests
[432/449] bitcoin: testing monolith_opcodes_tests
[433/449] Running utility command for check-bitcoin-monolith_opcodes_tests
[434/449] bitcoin: testing validation_block_tests
[435/449] Running utility command for check-bitcoin-validation_block_tests
[436/449] bitcoin: testing validation_tests
[437/449] Running utility command for check-bitcoin-validation_tests
[438/449] bitcoin: testing crypto_tests
[439/449] Running utility command for check-bitcoin-crypto_tests
[440/449] bitcoin: testing skiplist_tests
[441/449] Running utility command for check-bitcoin-skiplist_tests
[442/449] bitcoin: testing op_reversebytes_tests
[443/449] Running utility command for check-bitcoin-op_reversebytes_tests
[444/449] bitcoin: testing transaction_tests
[445/449] Running utility command for check-bitcoin-transaction_tests
[446/449] bitcoin: testing coins_tests
[447/449] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
baby636 added a reviewer: Fabien.
Fabien edited reviewers, added: baby636; removed: Fabien.