Page MenuHomePhabricator

[avalanche] Improve coverage for the addavalanchenode RPC
ClosedPublic

Authored by Fabien on Thu, Jul 15, 08:34.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC7da33a46ccb0: [avalanche] Improve coverage for the addavalanchenode RPC
Summary

This diff adds a new functional test for this RPC. Next step is to improve the error message.

Ref T1635.

Test Plan
./test/functional/test_runner.py abc_rpc_addavalanchenode

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Thu, Jul 15, 08:34
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/abc_rpc_addavalanchenode.py
68 ↗(On Diff #29177)

Why the comment?

This revision is now accepted and ready to land.Thu, Jul 15, 09:41
test/functional/abc_rpc_addavalanchenode.py
16 ↗(On Diff #29177)

-> int
This is wrong in abc_rpc_avalancheproof too

This revision was landed with ongoing or failed builds.Thu, Jul 15, 10:06
This revision was automatically updated to reflect the committed changes.