Page MenuHomePhabricator
Differential D9786

[avalanche] Improve coverage for the addavalanchenode RPC
ClosedPublic
Actions

Authored by Fabien on Jul 15 2021, 08:34.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC7da33a46ccb0: [avalanche] Improve coverage for the addavalanchenode RPC
Summary

This diff adds a new functional test for this RPC. Next step is to improve the error message.

Ref T1635.

Test Plan
./test/functional/test_runner.py abc_rpc_addavalanchenode

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_addavalanchenode_coverage
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16185
Build 32243: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32242: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 15 2021, 08:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2021, 08:34
Fabien requested review of this revision.Jul 15 2021, 08:34
Fabien added a child revision: D9787: [avalanche] Make the error code consistent in addavalanchenode.Jul 15 2021, 08:41
Harbormaster completed remote builds in B16177: Diff 29177.Jul 15 2021, 08:49
PiRK accepted this revision.Jul 15 2021, 09:41
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/abc_rpc_addavalanchenode.py
68 ↗(On Diff #29177)

Why the comment?

This revision is now accepted and ready to land.Jul 15 2021, 09:41
PiRK added inline comments.Jul 15 2021, 09:43
test/functional/abc_rpc_addavalanchenode.py
16 ↗(On Diff #29177)

-> int
This is wrong in abc_rpc_avalancheproof too

Fabien updated this revision to Diff 29189.Jul 15 2021, 10:03

Feedback

This revision was landed with ongoing or failed builds.Jul 15 2021, 10:06
Closed by commit rABC7da33a46ccb0: [avalanche] Improve coverage for the addavalanchenode RPC (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7da33a46ccb0: [avalanche] Improve coverage for the addavalanchenode RPC.
Harbormaster completed remote builds in B16185: Diff 29189.Jul 15 2021, 10:39

Revision Contents
Changeset List

PathSize
test/
functional/
109 lines

Diff 29189

View Options

test/functional/abc_rpc_addavalanchenode.py

Loading...