Differential D9787

[avalanche] Make the error code consistent in addavalanchenode
ClosedPublic
Actions

Authored by Fabien on Jul 15 2021, 08:41.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC7b604beb5ee0: [avalanche] Make the error code consistent in addavalanchenode

Summary

Deserialization errors should return a deserialization error.

Depends on D9786.

Ref T1635.

Test Plan

./test/functional/test_runner.py abc_rpc_addavalanchenode

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_addavalanchenode_error_code

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16178
Build 32229: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32228: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 15 2021, 08:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2021, 08:41

Fabien requested review of this revision.Jul 15 2021, 08:41

Harbormaster completed remote builds in B16178: Diff 29179.Jul 15 2021, 09:12

PiRK accepted this revision.Jul 15 2021, 09:43

This revision is now accepted and ready to land.Jul 15 2021, 09:43

Closed by commit rABC7b604beb5ee0: [avalanche] Make the error code consistent in addavalanchenode (authored by Fabien). · Explain WhyJul 15 2021, 10:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7b604beb5ee0: [avalanche] Make the error code consistent in addavalanchenode.

Revision Contents
Changeset List

Path

Size

src/

rpc/

avalanche.cpp

2 lines

test/

functional/

abc_rpc_addavalanchenode.py

4 lines

Diff 29179

View Options

src/rpc/avalanche.cpp