Page MenuHomePhabricator
Differential D9853

[avalanche] Reduce dependency to net.h from avalanche
ClosedPublic
Actions

Authored by Fabien on Aug 6 2021, 13:14.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC809ae45f349e: [avalanche] Reduce dependency to net.h from avalanche
Summary

This diff adds a nodeid.h header to remove the need for the net.h header from avalanche/node.h, and use forward declaration in processor.h. The other header changes come from previously indirectly included headers.

Depends on D9852.

Ref T1634.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 6 2021, 13:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2021, 13:14
Fabien requested review of this revision.Aug 6 2021, 13:14
Harbormaster completed remote builds in B16281: Diff 29345.Aug 6 2021, 13:31
majcosta accepted this revision.Aug 6 2021, 19:37
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/nodeid.h
10 ↗(On Diff #29345)

using NodeId = int64_t;

This revision is now accepted and ready to land.Aug 6 2021, 19:37
Fabien added a child revision: D9858: [avalanche] Protect from eviction the best node for each peer.Aug 9 2021, 14:58
Fabien added a comment.Aug 9 2021, 19:49

Let's keep this move only for now

Closed by commit rABC809ae45f349e: [avalanche] Reduce dependency to net.h from avalanche (authored by Fabien). · Explain WhyAug 9 2021, 19:50
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC809ae45f349e: [avalanche] Reduce dependency to net.h from avalanche.

Revision Contents
Changeset List

PathSize
src/
avalanche/
2 lines
2 lines
4 lines
8 lines
17 lines

Diff 29365

View Options

src/avalanche/node.h

Loading...
View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/processor.h

Loading...
View Options

src/net.h

Loading...
View Options

src/nodeid.h

Loading...