Differential D9886

refactor: use structured binding instead of first/second in processor_tests
ClosedPublic
Actions

Authored by majcosta on Aug 19 2021, 20:52.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC17ae0fce00b1: refactor: use structured binding instead of first/second in processor_tests

Summary

more readable, less code. fix a typo while at it.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

structured_binding_over_pair

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16345
Build 32553: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang · build-clang-tidy
Build 32552: arc lint + arc unit

Event Timeline

majcosta created this revision.Aug 19 2021, 20:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 19 2021, 20:52

majcosta requested review of this revision.Aug 19 2021, 20:52

deadalnix accepted this revision.Aug 19 2021, 20:58

This revision is now accepted and ready to land.Aug 19 2021, 20:58

Harbormaster completed remote builds in B16345: Diff 29440.Aug 19 2021, 21:11

Closed by commit rABC17ae0fce00b1: refactor: use structured binding instead of first/second in processor_tests (authored by majcosta). · Explain WhyAug 19 2021, 21:20

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC17ae0fce00b1: refactor: use structured binding instead of first/second in processor_tests.

PiRK mentioned this in D10116: fix compiler warning "Declaration shadows a local variable".Sep 14 2021, 16:15

PiRK mentioned this in rABCef3922c967a1: fix compiler warning "Declaration shadows a local variable".Sep 15 2021, 06:59

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

7 lines

Diff 29440

View Options

src/avalanche/test/processor_tests.cpp

refactor: use structured binding instead of first/second in processor_testsClosedPublicActions