Readd transactions in the mempool in the right order during reorg.
ClosedPublic
Actions

Authored by deadalnix on Jan 20 2018, 14:26.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9e9e088bcbfc: Readd transactions in the mempool in the right order during reorg.
rABC9e9e088bcbfc: Readd transactions in the mempool in the right order during reorg.

Summary

This ensures that no transaction is dropped from the mempool due to its parent not being included yet.

Include various other smaller changes such as using GetId instead of GetHash where apropriate, as well as formatting mempool_packages.py .

Test Plan

make check
./test/functional/test_runner.py mempool_packages.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1674
Build 1674: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 20 2018, 14:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2018, 14:26

Harbormaster completed remote builds in B1674: Diff 2606.Jan 20 2018, 14:27

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel retitled this revision from Readd transaction in the mempool in the right order during reorg. to Read transactions in the mempool in the right order during reorg..Jan 20 2018, 19:08

deadalnix retitled this revision from Read transactions in the mempool in the right order during reorg. to Reaad transactions in the mempool in the right order during reorg..Jan 20 2018, 19:20

schancel retitled this revision from Reaad transactions in the mempool in the right order during reorg. to Readd transactions in the mempool in the right order during reorg..Jan 20 2018, 19:54

schancel accepted this revision.Jan 20 2018, 23:11

This revision is now accepted and ready to land.Jan 20 2018, 23:11

Closed by commit rABC9e9e088bcbfc: Readd transactions in the mempool in the right order during reorg. (authored by deadalnix). · Explain WhyJan 20 2018, 23:17

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in T167: Revision D978 broke builds.Jan 20 2018, 23:17