Page MenuHomePhabricator
Differential D9916

net: fix use-after-free in tests
AbandonedPublic
Actions

Authored by PiRK on Aug 24 2021, 07:50.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

In PeerLogicValidation::PeerLogicValidation() we would schedule a lambda
function to execute later, capturing the local variable
consensusParams by reference.

Presumably this was considered safe because consensusParams is a
reference itself to a global variable which is not supposed to change,
but it can in tests.

Fixes https://github.com/bitcoin/bitcoin/issues/18372

This is a backport of core#18376

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Aug 24 2021, 07:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2021, 07:50
PiRK requested review of this revision.Aug 24 2021, 07:50
teamcity edited the summary of this revision. (Show Details)Aug 24 2021, 07:50
Harbormaster completed remote builds in B16386: Diff 29509.Aug 24 2021, 08:04
majcosta added a subscriber: majcosta.Aug 24 2021, 11:02

can you reproduce this tsan error? I can't

PiRK planned changes to this revision.Aug 24 2021, 13:15
In D9916#224207, @majcosta wrote:

can you reproduce this tsan error? I can't

No I can't either. I backported it to err on the side of caution.

But looking at some of the discussion (https://github.com/bitcoin/bitcoin/pull/18376#issuecomment-600775702), I think it is best to put this diff on standby as long as we don't see the error. What caused the issue for core is a controversial hack.

PiRK abandoned this revision.Aug 24 2021, 16:29

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 29509

View Options

src/net_processing.cpp

Loading...