Page MenuHomePhabricator
Differential D9920

qt: Add privacy feature to Overview page
ClosedPublic
Actions

Authored by PiRK on Aug 24 2021, 10:40.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC15c401ce02d3: qt: Add privacy feature to Overview page
Summary

This is a backport of core#16432 [2/2]

https://github.com/bitcoin/bitcoin/pull/16432/commits/8d75115844baefe5cad4d82ec8dce001dd16eb9c

Depends on D9919

Test Plan

ninja && src/qt/bitcoin-qt

Toggle the privacy option with Shift + Ctrl + M or through the menu.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 24 2021, 10:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2021, 10:40
PiRK requested review of this revision.Aug 24 2021, 10:40
teamcity edited the summary of this revision. (Show Details)Aug 24 2021, 10:41
PiRK edited the summary of this revision. (Show Details)Aug 24 2021, 10:42
PiRK added a parent revision: D9919: qt: Add BitcoinUnits::formatWithPrivacy() function.
PiRK added a child revision: D9921: qt: change BCH to XEC in QLabel's default text.Aug 24 2021, 10:49
Harbormaster completed remote builds in B16390: Diff 29513.Aug 24 2021, 10:56
majcosta requested changes to this revision.Aug 24 2021, 11:23
majcosta added a subscriber: majcosta.

please, make the cosmetic BCH -> XEC changes all in D9921 since they don't belong in the backport

This revision now requires changes to proceed.Aug 24 2021, 11:23
majcosta mentioned this in D9921: qt: change BCH to XEC in QLabel's default text.Aug 24 2021, 11:23
PiRK updated this revision to Diff 29515.Aug 24 2021, 12:58

undo the BCH -> XEC changes (see D9921)

PiRK updated this revision to Diff 29516.Aug 24 2021, 13:04

also undo changes related to number of decimals, will be done in D9921 too

Harbormaster completed remote builds in B16392: Diff 29515.Aug 24 2021, 13:11
Harbormaster completed remote builds in B16393: Diff 29516.Aug 24 2021, 13:16
majcosta accepted this revision.Aug 24 2021, 13:35
This revision is now accepted and ready to land.Aug 24 2021, 13:35
Closed by commit rABC15c401ce02d3: qt: Add privacy feature to Overview page (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyAug 24 2021, 15:20
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC15c401ce02d3: qt: Add privacy feature to Overview page.

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
17 lines
forms/
28 lines
2 lines
104 lines
test/
2 lines
2 lines
1 line
2 lines

Diff 29526

View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/forms/overviewpage.ui

Loading...
View Options

src/qt/overviewpage.h

Loading...
View Options

src/qt/overviewpage.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/qt/walletframe.cpp

Loading...
View Options

src/qt/walletview.h

Loading...
View Options

src/qt/walletview.cpp

Loading...