Page MenuHomePhabricator
Differential D9921

qt: change BCH to XEC in QLabel's default text
ClosedPublic
Actions

Authored by PiRK on Aug 24 2021, 10:49.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC37eac8110a16: qt: change BCH to XEC in QLabel's default text
Summary

I noticed while backporting core#16432 that there are some leftover instances of BCH in default values for widgets.

Test Plan

I don't know how to test this, those values are probably reinitialized in the code before the widgets are even visible, else we would have noticed the wrong "BCH" unit in the past.

I just compiled and ran bitcoin-qt to make sure everything works and looks normal.

Check that there aren't any occurences of BCH left:
grep BCH src/qt/forms/*.ui

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 24 2021, 10:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2021, 10:49
PiRK requested review of this revision.Aug 24 2021, 10:50
teamcity edited the summary of this revision. (Show Details)Aug 24 2021, 10:50
PiRK edited the summary of this revision. (Show Details)Aug 24 2021, 10:51
PiRK edited the test plan for this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)
majcosta added a subscriber: majcosta.Aug 24 2021, 11:10

nice catch

Harbormaster completed remote builds in B16391: Diff 29514.Aug 24 2021, 11:11
majcosta requested changes to this revision.Aug 24 2021, 11:23
majcosta mentioned this in D9920: qt: Add privacy feature to Overview page.

see feedback left on D9920

This revision now requires changes to proceed.Aug 24 2021, 11:23
PiRK updated this revision to Diff 29517.Aug 24 2021, 13:06
PiRK edited the summary of this revision. (Show Details)

include overviewpage.ui in this diff

Harbormaster completed remote builds in B16394: Diff 29517.Aug 24 2021, 13:19
majcosta accepted this revision.Aug 24 2021, 15:34
This revision is now accepted and ready to land.Aug 24 2021, 15:34
Closed by commit rABC37eac8110a16: qt: change BCH to XEC in QLabel's default text (authored by PiRK). · Explain WhyAug 24 2021, 16:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC37eac8110a16: qt: change BCH to XEC in QLabel's default text.

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
8 lines
16 lines
10 lines

Diff 29530

View Options

src/qt/forms/coincontroldialog.ui

Loading...
View Options

src/qt/forms/overviewpage.ui

Loading...
View Options

src/qt/forms/sendcoinsdialog.ui

Loading...