Page MenuHomePhabricator

qt: Reset toolbar after all wallets are closed
ClosedPublic

Authored by PiRK on Aug 31 2021, 06:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd4c384d91634: qt: Reset toolbar after all wallets are closed
Summary

If the last open wallet is closed from the non-"Overview" tab, that tab remains active when a new wallet is opened

This is a backport of core#18896

Test Plan

Run bitcoin-qt, go to any "non-Overview" tab, close the wallet, open it again and make sure the Overview tab is now active.

Event Timeline

PiRK requested review of this revision.Aug 31 2021, 06:50

Tail of the build log:

2021-08-31T07:17:08.388511Z   - Writing chainstate: 0.07ms [0.00s (0.07ms/blk)]
2021-08-31T07:17:08.388650Z UpdateTip: new best=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 version=0x00000001 log2_work=32.000022 tx=1 date='2009-01-03T18:15:05Z' progress=0.000000 cache=0.0MiB(0txo)
2021-08-31T07:17:08.388693Z   - Connect postprocess: 0.18ms [0.01s (1.38ms/blk)]
2021-08-31T07:17:08.388726Z - Connect block: 0.56ms [0.01s (1.79ms/blk)]
2021-08-31T07:17:08.388774Z Checking mempool with 0 transactions and 0 inputs
2021-08-31T07:17:08.388854Z Enqueuing BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0
2021-08-31T07:17:08.388953Z Enqueuing UpdatedBlockTip: new block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f fork block hash=null (in IBD=true)
2021-08-31T07:17:08.389562Z ERROR: DeserializeFileDB: Failed to open file /tmp/test_common_Bitcoin ABC/fef19998c583429fea90f14b7140dcf4feb4e7cc3f8daa3dc94ca7e6eaa02d2b/banlist.dat
2021-08-31T07:17:08.389596Z Invalid or missing banlist.dat; recreating
2021-08-31T07:17:08.393755Z Flushed 0 banned node ips/subnets to banlist.dat  4ms
2021-08-31T07:17:08.394125Z net: setting try another outbound peer=false
2021-08-31T07:17:08.394173Z SetNetworkActive: true
2021-08-31T07:17:08.411039Z BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0
2021-08-31T07:17:08.411129Z UpdatedBlockTip: new block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f fork block hash=null (in IBD=true)
2021-08-31T07:17:08.423243Z Seed: Setting random seed for current tests to RANDOM_CTX_SEED=62a70b421bca78fdd3eb44fd8821d8d3ca6c3372fc0481993c0c0575aa21a17e
2021-08-31T07:17:08.423343Z Bitcoin ABC version v0.24.1-5c4ae1404 (debug build)
2021-08-31T07:17:08.423536Z Checkpoints will be verified.
2021-08-31T07:17:08.423577Z Assuming ancestors of block 00000000000000000628880962d4adfe6e2fb8b303f8a700c4a006985596a719 have valid signatures.
2021-08-31T07:17:08.423611Z Setting nMinimumChainWork=00000000000000000000000000000000000000000155059db5fe1bf27f1ff6d8
2021-08-31T07:17:08.441097Z Using 32 MiB out of 32 requested for signature cache, able to store 1048576 elements
2021-08-31T07:17:08.455224Z Using 32 MiB out of 32 requested for script execution cache, able to store 1048576 elements
2021-08-31T07:17:08.455609Z Opened LevelDB successfully
2021-08-31T07:17:08.455680Z Using obfuscation key for /tmp/test_common_Bitcoin ABC/a4016ca3e2800cbe49a44ec9937525ee9b69a6ba7fb8976f0e7784c3e3b9e351/blocks/index: 0000000000000000
2021-08-31T07:17:08.455764Z Switching active chainstate to Chainstate [ibd] @ height -1 (null)
2021-08-31T07:17:08.455966Z Opened LevelDB successfully
2021-08-31T07:17:08.456060Z Wrote new obfuscate key for /tmp/test_common_Bitcoin ABC/a4016ca3e2800cbe49a44ec9937525ee9b69a6ba7fb8976f0e7784c3e3b9e351/chainstate: 3dba1f6cadf30aa6
2021-08-31T07:17:08.456105Z Using obfuscation key for /tmp/test_common_Bitcoin ABC/a4016ca3e2800cbe49a44ec9937525ee9b69a6ba7fb8976f0e7784c3e3b9e351/chainstate: 3dba1f6cadf30aa6
2021-08-31T07:17:08.456251Z Pre-allocating up to position 0x1000000 in blk00000.dat
2021-08-31T07:17:08.456592Z   - Load block from disk: 0.08ms [0.00s]
2021-08-31T07:17:08.456697Z BlockChecked: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f state=Valid
2021-08-31T07:17:08.456770Z   - Connect total: 0.18ms [0.00s (0.20ms/blk)]
2021-08-31T07:17:08.456815Z   - Flush: 0.05ms [0.00s (0.04ms/blk)]
2021-08-31T07:17:08.456941Z   - Writing chainstate: 0.07ms [0.00s (0.07ms/blk)]
2021-08-31T07:17:08.457086Z UpdateTip: new best=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f height=0 version=0x00000001 log2_work=32.000022 tx=1 date='2009-01-03T18:15:05Z' progress=0.000000 cache=0.0MiB(0txo)
2021-08-31T07:17:08.457129Z   - Connect postprocess: 0.24ms [0.01s (1.19ms/blk)]
2021-08-31T07:17:08.457164Z - Connect block: 0.62ms [0.01s (1.59ms/blk)]
2021-08-31T07:17:08.457217Z Checking mempool with 0 transactions and 0 inputs
2021-08-31T07:17:08.457301Z Enqueuing BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0
2021-08-31T07:17:08.457402Z Enqueuing UpdatedBlockTip: new block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f fork block hash=null (in IBD=true)
2021-08-31T07:17:08.458034Z ERROR: DeserializeFileDB: Failed to open file /tmp/test_common_Bitcoin ABC/a4016ca3e2800cbe49a44ec9937525ee9b69a6ba7fb8976f0e7784c3e3b9e351/banlist.dat
2021-08-31T07:17:08.458069Z Invalid or missing banlist.dat; recreating
2021-08-31T07:17:08.464994Z Flushed 0 banned node ips/subnets to banlist.dat  6ms
2021-08-31T07:17:08.465429Z net: setting try another outbound peer=false
2021-08-31T07:17:08.465480Z SetNetworkActive: true
2021-08-31T07:17:08.467092Z BlockConnected: block hash=000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f block height=0

2021-08-31T07:17:08.474471Z Enqueuing TransactionRemovedFromMempool: txid=0c0b213e7d4819fecb59a6f61f25a3a58c5daf4b3347a71b33a797a3e4e749bc
2021-08-31T07:17:08.475171Z Removed 1 txn, rolling minimum fee bumped to 803.65 XEC/kB
2021-08-31T07:17:08.476733Z Enqueuing TransactionRemovedFromMempool: txid=d2d612c94863898a5d1f5a756fe586f3f0d3a4afebe1e8a7eee4454c2c963000
2021-08-31T07:17:08.477817Z Removed 1 txn, rolling minimum fee bumped to 1597.30 XEC/kB
Segmentation fault (core dumped)
[423/453] Running pow test suite
PASSED: pow test suite
[443/453] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[445/453] Running secp256k1 test suite
PASSED: secp256k1 test suite
[449/453] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

rebase onto master (D9990 fixes CI build failure)

This revision is now accepted and ready to land.Aug 31 2021, 12:18