Page MenuHomePhabricator

Implement Amount class across the codebase
Closed, ResolvedPublic

Description

Per T4 we have created an Amount class which safeguards against the accidental non-monetary use of the value. This ticket represents switching from CAmount to Amount across the bitcoin-abc codebase.

Related Objects

Mentioned In
rABCba1ce56f40f1: Prepare qt package for explicit Amount construction
rABC4b01e6ddf4b4: Second patch to prepare tests for explicit Amount construction
rABCb1b55aaeacb4: Prepare remainder of wallet package for explicit Amount construction
rABC0b7abd9bd414: Prepare wallet for explicit Amount construction
D705: Prepare qt package for explicit Amount construction
D700: Second patch to prepare tests for explicit Amount construction
rABC5e74d11ac129: Prepare more files for explicit Amount constructor
rABCff61ed469906: Prepare several files for explicit Amount construction
rABC1f030a621887: Prepare several files for explicit Amount construction
rABCc38299b845ab: Prepare txmempool.cpp for explicit Amount construction
rABCbef95432d8a9: Prepare validation.cpp for explicit Amount construction
rABCfa450e0adbdf: Convert bitcoin-tx.cpp to use explicit Amount construction
rABC753b7f92768c: Prepare rpc package for explicit Amount construction
D681: Prepare rpc package for explicit Amount construction
D680: Prepare remainder of wallet package for explicit Amount construction
D679: Prepare validation.cpp for explicit Amount construction
D678: Prepare more files for explicit Amount constructor
D677: Prepare several files for explicit Amount construction
D676: Prepare several files for explicit Amount construction
D675: Prepare txmempool.cpp for explicit Amount construction
D674: Prepare wallet for explicit Amount construction
D673: Convert bitcoin-tx.cpp to use explicit Amount construction
rABC2b2332a59318: Convert rpcwallet.h/rpcwallet.cpp to use Amount class
D658: Convert rpcwallet.h/rpcwallet.cpp to use Amount class
rABCa6d986485a2d: Convert CWallet to use Amount class
rABC07bf7eb40078: Convert CAccountingEntry to use Amount class
T38: Implement a buildbot for master
D656: Convert CWallet to use Amount class
D655: Convert CAccountingEntry to use Amount class
rABC774f2c70a83f: Convert CMerkleTx to use Amount class
rABCbbde126ceb51: Convert CRecipient to use Amount class
rABC1ca92d607b7d: Convert COutputEntry to use Amount class
rABC88cf101d52ba: Finish converting CWalletTx to use Amount
D654: Convert CMerkleTx to use Amount class
D653: Convert CRecipient to use Amount class
D651: Convert COutputEntry to use Amount class
D650: Finish converting CWalletTx to use Amount
rABCb71d1337ac8d: Convert GetImmatureCredit to use Amount class
rABC4b608d26792b: Convert wallet GetDebit to use Amount class
D646: Convert GetImmatureCredit to use Amount class
rABC6180508fa3b1: Convert wallet GetCredit function to use Amount class
rABCb6ae3e587bca: Convert wallet GetChange method to use Amount
D645: Convert wallet GetDebit to use Amount class
D644: Convert wallet GetCredit function to use Amount class
D643: Convert wallet GetChange method to use Amount
rABCc0048b0cbf75: Change CAmount to Amount in CFeeRate tests (T104)
rABC83545547d8a6: Convert script package to use Amount struct (T104)

Event Timeline

schancel created this task.Sep 20 2017, 17:14
schancel triaged this task as High priority.Oct 16 2017, 17:45
schancel closed this task as Resolved.Dec 12 2017, 14:37