Page MenuHomePhabricator

Prepare qt package for explicit Amount construction
ClosedPublic

Authored by schancel on Nov 16 2017, 04:10.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Nov 16 2017, 04:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 04:10
deadalnix requested changes to this revision.Nov 16 2017, 10:28
deadalnix added inline comments.
src/qt/coincontroldialog.cpp
540 ↗(On Diff #1793)

nPayFee should be an Amount.

565 ↗(On Diff #1793)

dito for nChange.

629 ↗(On Diff #1793)

dito

This revision now requires changes to proceed.Nov 16 2017, 10:28
schancel updated this revision to Diff 1835.Nov 26 2017, 17:02
  • Address nits
schancel updated this revision to Diff 1838.Nov 26 2017, 17:43

Remove some accidental changes

deadalnix accepted this revision.Nov 26 2017, 17:50
deadalnix added inline comments.
src/qt/coincontroldialog.cpp
563 ↗(On Diff #1838)

The GetSatoshi here should not be necessary.

628 ↗(On Diff #1838)

formatWithUnit should take an Amount . May not be within the scope of this diff but it needs to happen.

This revision is now accepted and ready to land.Nov 26 2017, 17:50
This revision was automatically updated to reflect the committed changes.