Page MenuHomePhabricator

Prepare qt package for explicit Amount construction
ClosedPublic

Authored by schancel on Nov 16 2017, 04:10.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explicit-qt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1151
Build 1151: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Nov 16 2017, 10:28
deadalnix added inline comments.
src/qt/coincontroldialog.cpp
540

nPayFee should be an Amount.

565

dito for nChange.

629

dito

This revision now requires changes to proceed.Nov 16 2017, 10:28

Remove some accidental changes

deadalnix added inline comments.
src/qt/coincontroldialog.cpp
563 ↗(On Diff #1838)

The GetSatoshi here should not be necessary.

628 ↗(On Diff #1838)

formatWithUnit should take an Amount . May not be within the scope of this diff but it needs to happen.

This revision is now accepted and ready to land.Nov 26 2017, 17:50
This revision was automatically updated to reflect the committed changes.