Paths

Table of Contentst

Prepare qt package for explicit Amount construction
ClosedPublic
Actions

Authored by schancel on Nov 16 2017, 04:10.

Details

Reviewers

deadalnix
freetrader
mbhinder

Group Reviewers

Restricted Project

Commits

rSTAGINGba1ce56f40f1: Prepare qt package for explicit Amount construction
rABCba1ce56f40f1: Prepare qt package for explicit Amount construction

Summary

Continue T104

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

explicit-qt

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1151
Build 1151: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 16 2017, 04:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2017, 04:10

Harbormaster completed remote builds in B1151: Diff 1793.Nov 16 2017, 04:10

deadalnix requested changes to this revision.Nov 16 2017, 10:28

deadalnix added inline comments.

src/qt/coincontroldialog.cpp
540	nPayFee should be an Amount.
565	dito for nChange.
629	dito

This revision now requires changes to proceed.Nov 16 2017, 10:28

Address nits

Remove some accidental changes

Harbormaster completed remote builds in B1176: Diff 1838.Nov 26 2017, 17:43

deadalnix accepted this revision.Nov 26 2017, 17:50

deadalnix added inline comments.

src/qt/coincontroldialog.cpp
563 ↗	(On Diff #1838)	The GetSatoshi here should not be necessary.
628 ↗	(On Diff #1838)	`formatWithUnit` should take an `Amount` . May not be within the scope of this diff but it needs to happen.

This revision is now accepted and ready to land.Nov 26 2017, 17:50

Closed by commit rABCba1ce56f40f1: Prepare qt package for explicit Amount construction (authored by schancel). · Explain WhyNov 26 2017, 18:05

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinamountfield.cpp

2 lines

coincontroldialog.cpp

25 lines

2 lines

4 lines

12 lines

6 lines

transactionrecord.cpp

12 lines

transactionview.cpp

2 lines

walletmodel.cpp

18 lines

walletmodeltransaction.cpp

4 lines

Diff 1793

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/qt/walletmodeltransaction.cpp

Prepare qt package for explicit Amount constructionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1793

src/qt/bitcoinamountfield.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentserver.cpp

src/qt/sendcoinsdialog.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.cpp

src/qt/walletmodeltransaction.cpp

Prepare qt package for explicit Amount construction
ClosedPublic
Actions

Revision Contents
Changeset List