Page MenuHomePhabricator
Create Task
Maniphest T524

Improve IBD script to support arbitrary params
Closed, ResolvedPublic
Actions

Description

The goal is to write a script that we can run once and will run IBD on master every 24 hours or so. Breakdown of the script:

  • Pull latest Bitcoin ABC master
  • Build bitcoind
  • Clear blockchain files (but not configs) in ~/.bitcoin/
  • Spin up bitcoind node
  • Wait for IBD to complete

This script should run be able to be run via chron and TeamCity.

Update: The above isn't quite necessary since contrib/teamcity/ibd.sh already exists. Rather than rewrite it, we can simply update it to allow different parameters for different runs. TeamCity should be able to call this script with -assumevalid=0 -checkpoints=0 so that we no longer need to do this manually during releases.

Another way this script can be improved is to only run if the previous run has a different HEAD commit than latest master, though this feature isn't strictly necessary for MVP.

Related Objects

Event Timeline

jasonbcox triaged this task as High priority.Jan 18 2019, 00:44
jasonbcox created this task.
jasonbcox updated the task description. (Show Details)Jan 30 2019, 00:35
jasonbcox added a comment.Feb 25 2019, 20:25

This script already exists, for the most part: contrib/teamcity/ibd.sh Update it so that we can pass in -assumevalid=0 -checkpoints=0

nakihito mentioned this in D2612: Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call..Feb 26 2019, 19:04
jasonbcox updated the task description. (Show Details)Feb 26 2019, 19:54
jasonbcox updated the task description. (Show Details)
jasonbcox renamed this task from Write a continuous IBD script to Improve IBD script to support arbitrary params.Feb 27 2019, 20:35
Diffusion mentioned this in rABC86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to….Mar 1 2019, 22:43
schancel added a subscriber: schancel.Mar 9 2019, 21:35

Another way this script can be improved is to only run if the previous run has a different HEAD commit than latest master, though this feature isn't strictly necessary for MVP.

@jasonbcox What does this mean? This is a configurable parameter in TeamCity -- I turned it off to ensure there is more testing runs for non-deterministic failures. If you want it off, it's easy to adjust the trigger condition.

nakihito closed this task as Resolved.Apr 26 2019, 22:03
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGING86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to….Sep 18 2019, 22:37