Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call.
ClosedPublic
Actions

Authored by nakihito on Feb 26 2019, 19:04.

Details

Reviewers

deadalnix
jasonbcox
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to…
rABC86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to…

Summary

Updated IBD script to take bitcoind options as parameters and pass them directly to the bitcoind call. Also changed the bitcoind call to not run in the background so the script terminates when finished. Completes T524.

Test Plan

ibd.sh -assumevalid=0 -checkpoints=0 -disablewallet
Check debug.log and you should find:

2019-02-27T00:16:09Z Validating signatures for all blocks.

2019-02-27T00:16:14Z Wallet disabled!

There should be no log message for checkpoints.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Feb 26 2019, 19:04

Owners added a reviewer: Restricted Owners Package.Feb 26 2019, 19:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 19:04

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Feb 26 2019, 19:06

nakihito removed a subscriber: schancel.

jasonbcox requested changes to this revision.Feb 26 2019, 19:17

jasonbcox added inline comments.

contrib/teamcity/ibd.sh
25 ↗	(On Diff #7486)	Any reason `$*` can't be used in the place of `$PARAMS` entirely so this line can be removed?
27 ↗	(On Diff #7486)	removing `&` doesn't match what this diff is intending to do. and it doesn't appear to achieve anything. Please undo.

This revision now requires changes to proceed.Feb 26 2019, 19:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5076: Diff 7486.Feb 26 2019, 19:18

Readded background option for bitcoind call and removed PARAMS variable.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5078: Diff 7489.Feb 26 2019, 19:38

Testplan should indicate that the params passed in were verified in logs or otherwise

This revision now requires changes to proceed.Feb 26 2019, 20:26

nakihito edited the test plan for this revision. (Show Details)Feb 27 2019, 00:46

Rebased.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5119: Diff 7560.Mar 1 2019, 20:12

nakihito edited the test plan for this revision. (Show Details)Mar 1 2019, 22:40

I will update the TeamCity config to the following once this is landed:

Existing IBD will have -disablewallet added to ensure the config behavior remains the same
A new IBD setting will be added with -disablewallet -assumevalid=0 -checkpoints=0

This revision is now accepted and ready to land.Mar 1 2019, 22:42

Closed by commit rABC86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to… (authored by nakihito). · Explain WhyMar 1 2019, 22:43

This revision was automatically updated to reflect the committed changes.

jasonbcox mentioned this in D2637: Fix a bug in ibd.sh where multiple args provided to the script would not be parsed correctly.Mar 2 2019, 00:18

jasonbcox mentioned this in rABCf9c866be05a6: Fix a bug in ibd.sh where multiple args provided to the script would not be….Mar 2 2019, 01:31

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to….Sep 18 2019, 22:37

jasonbcox mentioned this in rSTAGINGf9c866be05a6: Fix a bug in ibd.sh where multiple args provided to the script would not be….Sep 18 2019, 22:37