Page MenuHomePhabricator

Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call.
ClosedPublic

Authored by nakihito on Tue, Feb 26, 19:04.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC86594408f2fa: Updated ibd.sh script to take bitcoind options and then pass them directly to…
Summary

Updated IBD script to take bitcoind options as parameters and pass them directly to the bitcoind call. Also changed the bitcoind call to not run in the background so the script terminates when finished. Completes T524.

Test Plan

ibd.sh -assumevalid=0 -checkpoints=0 -disablewallet
Check debug.log and you should find:

2019-02-27T00:16:09Z Validating signatures for all blocks.
2019-02-27T00:16:14Z Wallet disabled!

There should be no log message for checkpoints.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Feb 26, 19:04
Owners added a reviewer: Restricted Owners Package.Tue, Feb 26, 19:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 26, 19:04
Herald added a subscriber: schancel. · View Herald Transcript
nakihito edited the test plan for this revision. (Show Details)Tue, Feb 26, 19:06
nakihito removed a subscriber: schancel.
jasonbcox requested changes to this revision.Tue, Feb 26, 19:17
jasonbcox added inline comments.
contrib/teamcity/ibd.sh
25 ↗(On Diff #7486)

Any reason $* can't be used in the place of $PARAMS entirely so this line can be removed?

27 ↗(On Diff #7486)

removing & doesn't match what this diff is intending to do.
and it doesn't appear to achieve anything. Please undo.

This revision now requires changes to proceed.Tue, Feb 26, 19:17
nakihito updated this revision to Diff 7489.Tue, Feb 26, 19:25

Readded background option for bitcoind call and removed PARAMS variable.

jasonbcox requested changes to this revision.Tue, Feb 26, 20:26

Testplan should indicate that the params passed in were verified in logs or otherwise

This revision now requires changes to proceed.Tue, Feb 26, 20:26
nakihito edited the test plan for this revision. (Show Details)Wed, Feb 27, 00:46
nakihito updated this revision to Diff 7560.Fri, Mar 1, 19:58

Rebased.

nakihito edited the test plan for this revision. (Show Details)Fri, Mar 1, 22:40
jasonbcox accepted this revision.Fri, Mar 1, 22:42

I will update the TeamCity config to the following once this is landed:

  1. Existing IBD will have -disablewallet added to ensure the config behavior remains the same
  2. A new IBD setting will be added with -disablewallet -assumevalid=0 -checkpoints=0
This revision is now accepted and ready to land.Fri, Mar 1, 22:42
This revision was automatically updated to reflect the committed changes.