HomePhabricator

Recent Activity
ActivePublic

Recent Activity

Today

PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Thu, Mar 6, 17:34
PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Thu, Mar 6, 17:32
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

add tests for incorrect data length in otherwise valid succession of push ops

Thu, Mar 6, 17:28
PiRK requested review of D17760: [electrum] implement eMPP parsing.
Thu, Mar 6, 16:41
PiRK updated the diff for D17758: [electrum] rename package slp -> tokens.

make this a move only commit

Thu, Mar 6, 16:40
PiRK updated the summary of D17759: [electrum] add copyright header to slp.py.
Thu, Mar 6, 16:39
PiRK requested review of D17759: [electrum] add copyright header to slp.py.
Thu, Mar 6, 16:35
PiRK planned changes to D17758: [electrum] rename package slp -> tokens.

let's add the headers in a separate diff, so it is clear that no code was changed

Thu, Mar 6, 16:32
PiRK requested review of D17758: [electrum] rename package slp -> tokens.
Thu, Mar 6, 16:31
PiRK requested review of D17757: [electrum] import the slp module directly.
Thu, Mar 6, 16:30
bytesofman requested review of D17755: [monorepo] eslint all the js with a single version-pinned flat config.

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

On another note, I'm getting the following from arc lint --everything

image.png (245×1 px, 37 KB)

However, arc lint on the cashtab folder runs fine, which doesn't seem to be a local issue?

image.png (55×512 px, 9 KB)

Thu, Mar 6, 11:30
Fabien updated the summary of D13068: [avalanche] Add transaction management to the processor core.
Thu, Mar 6, 09:54
PiRK closed D17753: test: adjust chainstate tests to use recognized snapshot base.
Thu, Mar 6, 09:35
PiRK committed rABC43c4d6926372: test: adjust chainstate tests to use recognized snapshot base (authored by James O'Beirne <james.obeirne@pm.me>).
test: adjust chainstate tests to use recognized snapshot base
Thu, Mar 6, 09:35
Unknown Object (User) updated the summary of D13068: [avalanche] Add transaction management to the processor core.
Thu, Mar 6, 09:28
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Squashed commits as requested and removed unnecessary useEffec

Thu, Mar 6, 09:20
Fabien added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

This is a update.
Perhaps my update method wasn't quite right? It created a new sub-diff, this is the initial submission https://reviews.bitcoinabc.org/D17756?id=52941

Thu, Mar 6, 09:00
alitayin added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Thu, Mar 6, 08:49
Fabien accepted D17753: test: adjust chainstate tests to use recognized snapshot base.
Thu, Mar 6, 08:44
alitayin retitled D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling from Add click-outside-area closing effect for NavWrapper using event bubbling to [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.
Thu, Mar 6, 08:40
Fabien added a comment to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Please prefix your title with [cashtab] so we now in the review queue what part of the code is changed

Thu, Mar 6, 08:13
Fabien added a comment to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

On another note, I'm getting the following from arc lint --everything

image.png (245×1 px, 37 KB)

However, arc lint on the cashtab folder runs fine, which doesn't seem to be a local issue?

image.png (55×512 px, 9 KB)

Thu, Mar 6, 08:10
emack requested changes to D17755: [monorepo] eslint all the js with a single version-pinned flat config.

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

Thu, Mar 6, 07:21
emack requested changes to D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Thu, Mar 6, 06:58
alitayin updated the diff for D17756: [Cashtab] Add click-outside-area closing effect for NavWrapper using event bubbling.

Remove useEffect

Thu, Mar 6, 05:27

Panel Used By

Event Timeline

deadalnix renamed this panel from to Recent Activity.May 14 2017, 23:39
deadalnix edited an edge.
deadalnix edited an edge.
deadalnix changed the visibility from "All Users" to "Public (No Login Required)".
deadalnix edited a custom field.