Differential D3574

Use cstdint in generated test headers
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2019, 13:09.

Tags

None

Subscribers

Details

Reviewers

markblundeberg
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING816d31b4f1da: Use cstdint in generated test headers
rABC816d31b4f1da: Use cstdint in generated test headers

Summary

It is more in line with the style we are adopting.

Test Plan

make clean
make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cstdintcodegen

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6702
Build 11451: Bitcoin ABC Buildbot (legacy)
Build 11450: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2019, 13:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 13:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6702: Diff 10047.Jul 7 2019, 13:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added a subscriber: markblundeberg.Jul 8 2019, 00:15

markblundeberg added inline comments.

src/test/CMakeLists.txt
132	I can't see what's changing here, also... unrelated?

markblundeberg requested changes to this revision.Jul 8 2019, 01:36

This revision now requires changes to proceed.Jul 8 2019, 01:36

deadalnix requested review of this revision.Jul 8 2019, 12:46

deadalnix added inline comments.

src/test/CMakeLists.txt
132	It's a whitespace change. Someone misconfigured their text editor.

Fabien accepted this revision.Jul 8 2019, 12:53

markblundeberg accepted this revision.Jul 8 2019, 13:18

markblundeberg added inline comments.

src/test/CMakeLists.txt
132	Oh yeah I can see it now (by clicking 'view left file' and 'view right file'). Annoyingly, phab renders a tab as two spaces so they look identical here, hah.

This revision is now accepted and ready to land.Jul 8 2019, 13:18

Closed by commit rABC816d31b4f1da: Use cstdint in generated test headers (authored by deadalnix). · Explain WhyJul 8 2019, 14:16

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC816d31b4f1da: Use cstdint in generated test headers.

deadalnix added a commit: rSTAGING816d31b4f1da: Use cstdint in generated test headers.Sep 19 2019, 01:03

Revision Contents
Changeset List

Path

Size

src/

test/

2 lines

data/

generate_header.py

3 lines

Diff 10047

src/test/CMakeLists.txt

Loading...

src/test/data/generate_header.py

Loading...