Move CheckBlock() call to critical section
ClosedPublic
Actions

Authored by Fabien on Jul 9 2019, 12:40.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc9b857a42499: Move CheckBlock() call to critical section
rABCc9b857a42499: Move CheckBlock() call to critical section

Summary

This prevents data race for CBlock::fChecked.

Backport of core PR14841
https://github.com/bitcoin/bitcoin/pull/14841/files

Test Plan

With TSAN enabled:

./src/test/test_bitcoin -t validation_block_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14841

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6755
Build 11557: Bitcoin ABC Buildbot (legacy)
Build 11556: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 9 2019, 12:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 12:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6755: Diff 10127.Jul 9 2019, 12:46

deadalnix accepted this revision.Jul 9 2019, 20:12

This revision is now accepted and ready to land.Jul 9 2019, 20:12

Closed by commit rABCc9b857a42499: Move CheckBlock() call to critical section (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyJul 9 2019, 22:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc9b857a42499: Move CheckBlock() call to critical section.

Fabien added a commit: rSTAGINGc9b857a42499: Move CheckBlock() call to critical section.Sep 19 2019, 01:07

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

10 lines

Diff 10127

View Options

Move CheckBlock() call to critical sectionClosedPublicActions