Page MenuHomePhabricator
Differential D3606

tests: Fix lock-order-inversion (potential deadlock) in DoS_tests.
ClosedPublic
Actions

Authored by Fabien on Jul 9 2019, 12:03.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6662b89b2fd6: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests.
rABC6662b89b2fd6: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests.
Summary
Reported by TSAN.

Makes `src/test/test_bitcoin --run_test=DoS_tests` pass also when
compiled with TreadSanitizer (`./configure --with-sanitizers=thread`).

Backport of core PR12882
https://github.com/bitcoin/bitcoin/pull/12882/files

Test Plan
mkdir build && cd build
../configure --with-sanitizers=thread
make
export TSAN_OPTIONS="suppressions=${PWD}/../test/sanitizer_suppressions/tsan"
./src/test/test_bitcoin -t denialofservice_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12882
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6763
Build 11573: Bitcoin ABC Buildbot (legacy)
Build 11572: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 9 2019, 12:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 12:03
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 9 2019, 12:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6754: Diff 10126.Jul 9 2019, 12:10
teamcity added a comment.Jul 9 2019, 12:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jul 9 2019, 12:13
deadalnix added inline comments.
test/sanitizer_suppressions/tsan
17 ↗(On Diff #10126)

This doesn't looks like it is related.

This revision now requires changes to proceed.Jul 9 2019, 12:13
Fabien updated this revision to Diff 10137.Jul 9 2019, 16:45

Remove unrelated tsan edit.

teamcity added a comment.Jul 9 2019, 16:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2019, 16:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6763: Diff 10137.Jul 9 2019, 16:52
deadalnix accepted this revision.Jul 9 2019, 17:28
This revision is now accepted and ready to land.Jul 9 2019, 17:28
Closed by commit rABC6662b89b2fd6: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests. (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJul 9 2019, 18:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6662b89b2fd6: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests..
Fabien mentioned this in D3784: Fix missing lock in denialofservice_tests.Jul 31 2019, 13:43
Fabien mentioned this in rABC4f7faba9489e: Fix missing lock in denialofservice_tests.Aug 5 2019, 07:15
Fabien added a commit: rSTAGING6662b89b2fd6: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests..Sep 19 2019, 01:07
Fabien mentioned this in rSTAGING4f7faba9489e: Fix missing lock in denialofservice_tests.Sep 19 2019, 01:36
PiRK mentioned this in D9689: [tests] Remove unnecessary cs_mains in denialofservice_tests.Jun 16 2021, 16:07
PiRK mentioned this in rABC41a27535979f: [tests] Remove unnecessary cs_mains in denialofservice_tests.Jun 17 2021, 07:33

Revision Contents
Changeset List

PathSize
src/
3 lines
test/
77 lines

Diff 10137

View Options

src/net_processing.h

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...