Page MenuHomePhabricator
Differential D3661

[wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 13:37.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH
Summary

Only if -changetype is not set and -addresstype is not "legacy".

This is a backport of Core PR12119

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12119
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6835
Build 11717: Bitcoin ABC Buildbot (legacy)
Build 11716: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 12 2019, 13:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 13:37
teamcity added a comment.Jul 12 2019, 13:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 13:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6835: Diff 10258!Jul 12 2019, 13:39
deadalnix added a child revision: D3662: [wallet] Add change type to CCoinControl.Jul 12 2019, 15:15
jasonbcox added a subscriber: jasonbcox.Jul 12 2019, 15:46

Why backport this? We haven't been supporting other address types (especially bech32).

src/wallet/wallet.cpp
3010

iirc LearnRelatedScripts wasn't backported either.

teamcity added a comment.Jul 12 2019, 20:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 12 2019, 20:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox accepted this revision.Jul 15 2019, 16:24

Talked about it offline. This isn't about backporting for usefulness, but rather paring down ownership on parts of the codebase that we do not want to own at this time.

This revision is now accepted and ready to land.Jul 15 2019, 16:24
teamcity added a comment.Jul 15 2019, 16:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6835: Diff 10258.Jul 15 2019, 16:54
teamcity added a comment.Jul 15 2019, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by deadalnix). · Explain WhyJul 15 2019, 19:20
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.
deadalnix added a commit: rSTAGING79fdaf1e1e25: [wallet] use P2WPKH change output if any destination is P2WPKH or P2WSH.Sep 19 2019, 01:16

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines
wallet/
6 lines
2 lines
22 lines

Diff 10258

View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...