remove ComparisonTestFramework dependency from segwit recovery test
ClosedPublic
Actions

Authored by markblundeberg on Jul 14 2019, 01:55.

Details

Reviewers

deadalnix
Fabien
Mengerian

Group Reviewers

Restricted Project

Commits

rSTAGINGbe9526156bce: remove ComparisonTestFramework dependency from segwit recovery test
rABCbe9526156bce: remove ComparisonTestFramework dependency from segwit recovery test

Summary

This borrows the approach from D3601.

Test Plan

./test/functional/test_runner.py abc-segwit-recovery.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

swcomp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6857
Build 11761: Bitcoin ABC Buildbot (legacy)
Build 11760: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 14 2019, 01:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2019, 01:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6857: Diff 10287.Jul 14 2019, 02:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Note that rejected and reconnect_p2p don't actually get used in this test; could probably be taken out. Initially I was thinking they might come in useful later, now I can't imagine that anything like that would be added.

deadalnix accepted this revision.Jul 14 2019, 16:56

This revision is now accepted and ready to land.Jul 14 2019, 16:56

Closed by commit rABCbe9526156bce: remove ComparisonTestFramework dependency from segwit recovery test (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 15 2019, 00:46

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCbe9526156bce: remove ComparisonTestFramework dependency from segwit recovery test.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGbe9526156bce: remove ComparisonTestFramework dependency from segwit recovery test.Sep 19 2019, 01:15

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-segwit-recovery.py

122 lines

Diff 10287

View Options

test/functional/abc-segwit-recovery.py

remove ComparisonTestFramework dependency from segwit recovery testClosedPublicActions